apps: Adds CPU, memory, and network usage graph dock-apps.#431
Open
ideasman42 wants to merge 2 commits intophkaeser:mainfrom
Open
apps: Adds CPU, memory, and network usage graph dock-apps.#431ideasman42 wants to merge 2 commits intophkaeser:mainfrom
ideasman42 wants to merge 2 commits intophkaeser:mainfrom
Conversation
ideasman42
force-pushed
the
pr-graph
branch
10 times, most recently
from
aa2c0cd to
9899e3a
Compare
Owner
|
Thanks for the pull request! To manage expectations: It might take me a few days to find capacity to review this with the quality it deserves (it's good! it's also a lot of lines! :-) ). |
ideasman42
force-pushed
the
pr-graph
branch
2 times, most recently
from
f8342ce to
0e952f1
Compare
phkaeser
reviewed
Jan 31, 2026
Owner
phkaeser
left a comment
phkaeser
left a comment
There was a problem hiding this comment.
Thank you so much for the contribution! Code looks overall well readable, and consistent with style used throughout. I left a few comments where IMHO existing libbase functionality can be used (and shorten the code a bit); minor observations only.
Additionally: As extra tools, I believe the tools should also come with a .desktop file, similar to https://github.com/phkaeser/wlmaker/blob/main/share/wlmaker.wlmclock.desktop.in.
Can you please add one for each?
apps/wlm_graph_utildefines.h
Outdated
| #define MIN2(a, b) ((a) < (b) ? (a) : (b)) | ||
|
|
||
| /** Returns the maximum of two values. */ | ||
| #define MAX2(a, b) ((a) > (b) ? (a) : (b)) |
- Replace fprintf(stderr, ...) with bs_log() for consistent logging. - Remove panic_fn callback in favor of direct bs_log. - Use BS_MIN/BS_MAX from libbase instead of local MIN2/MAX2 macros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three dock-apps that display system usage graphs:
Other notes:
Implementation
Known Limitations
This line is always 1 pixel high, it doesn't support fractional scaling.