Update README.md

[sebastianstucke87]

Updated code style:

• strict_types
• final readonly class
• promoted properties
• void return
• NullLogger instead of dealing with null (thereby removing the null-pointer exception I added in 2019...)
• handle \Throwable
• short-array syntax

[Seldaek]

If you want to do modern PHP, IMO it's best to leave $logger nullable and call it conditionally with:

Suggested change

	$this->logger->info('Doing work');
	$this->logger?->info('Doing work');

That avoids useless method calls and a useless NullLogger instance.

[sebastianstucke87]

Depends.

That means:

• having your code riddled with "?->"
• depending on a static code analysis tool (like PHPStan or Psalm) to prevent nullpointer exceptions

I think this is more a question of deprecating "NullLogger" or not (which is out of scope for this PR).

Personally, I like to keep it simple and stick to OOP with DI, since it is language agnostic.

[stof]

I don't see why this package should deprecate NullLogger. Both NullLogger and the nullsafe operator are valid ways to solve the case of the optional logger in the constructor

Personally, I like to keep it simple and stick to OOP with DI, since it is language agnostic.

being language agnostic does not make sense when writing a code snippet for PHP.

And if you mean avoiding features that don't directly translate to other OOP languages, your argument is void IMO:

• you are using constructor promoted properties, which have a direct equivalent in very few other languages
• the nullsafe operator exists in most modern languages

[andrew-demb]

Is it a recommended way to handle with no logs - pass a null , not NullLogger?