Conversation
asgrim
reviewed
Dec 20, 2024
Contributor
Dang! That's frustrating, but yeah the approach you've taken is fine given that 👍 thank you @alexandre-daubois :) |
alexandre-daubois
force-pushed
the
trim-warning-deprecated
branch
2 times, most recently
from
7162e1b to
b3e6c16
Compare
alexandre-daubois
force-pushed
the
trim-warning-deprecated
branch
from
b3e6c16 to
0e8020c
Compare
asgrim
approved these changes
Dec 23, 2024
Contributor
|
Nice one, thanks @alexandre-daubois ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #146
Adds a way to trim
Deprecated:andWarning:from output. This is not only limited toassertValidLookingPhpBinary, but to all PHP subprocess invocation.Unfortunately, warning messages are sent to
stdout, notstderr.The cleaning only happens during some setup/validation step of the current env, and the deprecations and warnings are still being displayed to the user when compiling the extension. This way, there's no "sneaky hiding" of error:
I added a parameter to the
Process::run()method, but if we don't want to add it, the output could also be directly cleaned in thePhpBinaryPath. Indeed, I'm not 100% happy of this parameter, which is really "PHP-subprocess-related" in a class that is not limited to PHP subprocesses.