Fix false positive for aliases matching PHP class names#717
Open
podlesny-j wants to merge 3 commits intophpstan:2.0.xfrom
Open
Fix false positive for aliases matching PHP class names#717podlesny-j wants to merge 3 commits intophpstan:2.0.xfrom
podlesny-j wants to merge 3 commits intophpstan:2.0.xfrom
Conversation
When a QueryBuilder alias like 'event' coincidentally matches an existing PHP class name (e.g. \Event from ext-event stubs), isClassString() returns yes and isTransient() returns true, causing a DynamicQueryBuilderArgumentException. This made the query type resolve to mixed instead of the correct entity type. Invert the transient check so that only non-transient (actual entity) class-strings are resolved to their FQCN. Transient class-strings now fall through to constant scalar handling, where they are treated as plain string aliases. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
janedbal
reviewed
Jan 29, 2026
janedbal
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a QueryBuilder alias like 'event' coincidentally matches an
existing PHP class name (e.g. \Event from ext-event stubs),
isClassString() returns yes and isTransient() returns true, causing
a DynamicQueryBuilderArgumentException. This made the query type
resolve to mixed instead of the correct entity type.
The
isTransientcheck inArgumentsProcessor::processArgs()is now scoped to only the firstargument of from/join/innerJoin/leftJoin/rightJoin methods. For all other methods and argument
positions, class-strings that happen to match a PHP class name fall through to constant scalar
handling. This preserves the error for genuinely passing a non-entity class to from/join, while
fixing the false positive for aliases like 'event'.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com and janedbal
based on #609