Adding scroll event to capture vertical position#162
Open
surajhell88 wants to merge 4 commits intophuocng:masterfrom
Open
Adding scroll event to capture vertical position#162surajhell88 wants to merge 4 commits intophuocng:masterfrom
surajhell88 wants to merge 4 commits intophuocng:masterfrom
Conversation
… throttle helper to minimise the calls to scroll function.
Contributor
Author
|
@phuoc-ng This works for both header click as well as browser back button click. I also tested it for Chrome, Brave, Firefox & Safari. Do review changes and let me know if you need any change. |
Contributor
Author
|
@phuoc-ng Please do let me know if you need any corrections in the code I've submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adding throttle helper to minimize the callbacks.