Update README.md

[jcstang]

added a docker compose option when upgrading.

Description

Added a line that talked about docker compose.

Motivation and Context

Clarify for users like me who use docker compose vs docker run.

How Has This Been Tested?

n/a

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• na

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[yubiuser]

Why did you change the styling here?

[jcstang]

I just meant to change the styling for "Just to prove you can.". Thought an emphasis on this phrase would be impactful.

[yubiuser]

Suggested change

	New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! **Just to prove you can.**
	New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often!

I think this could even be removed.

[PromoFaux]

Suggested change

	2. Throw away your container: `docker rm -f pihole`
	2. Throw away your container: `docker compose down`

[PromoFaux]

We should probably switch this up for a compose command, too. Otherwise it doesn't make a lot of sense in the grand scheme of things.

[rdwebdesign]

I'm undecided here... We have a few places suggesting docker run commands and arguments in the Docs and in the README:

• Docs page shows both commands: https://docs.pi-hole.net/docker/
• This table uses docker run format for all arguments;
• this line shows a docker run argument;
• this line uses both (docker run and docker compose).

Maybe we could suggest both commands:

Suggested change

	2. Throw away your container: `docker rm -f pihole`
	2. Throw away your container: `docker rm -f pihole` or `docker compose down`, depending on how you started your container.

And also change the step 3., adding:

-3. Start your container with the newer base image: `docker compose up -d` 
+3. Start your container with the newer base image: `docker compose up -d` or `docker run <args>`

[yubiuser]

I would switch everything to compose syntax. Are users really running docker run by hand with all the necessary options/flags?

[PromoFaux]

Are users really running docker run

The trick is never to be surprised, and then they cannot surprise you.

[casperklein]

You can avoid the docker compose down step by using: docker compose pull && docker compose up --force-recreate

https://docs.docker.com/reference/cli/docker/compose/up/

Edit:

Or as a one-liner: docker compose up --force-recreate --pull always -d

This downloads the latest image, stops and removes the currently running container, creates a new one, and starts it.