Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I'm not sure if these options are available on the new system, but do we need them?
The new search window is a little different, but it also shows all results in real time while you type the search string, like mkdocs search. Not sure if the suggestions are needed. |
|
The whole search was completely re-implemented. We probably don't need Note: I removed |
Not sure if we really need this.
Can you provide a screenshot using the "classic" theme? |
It depends if they implement warning about files not included in the navigation. Tracking here: zensical/zensical#124
This is 1:1 the current Materials for MkDocs theme we use. So all screenshots are at https://docs.pi-hole.net/ |
i vote modern. (though i'm sure my vote doesnt count much😂😂) |
204e8b4 to
30ae486
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
…e outside of `docs` which we should also consider Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
|
Conflicts have been resolved. |
What does this PR aim to accomplish?:
mkdocs-materialis in maintenance mode and their creators build a new site generation tool calledzensical(here). It offers a back-wards compatibility tomkdocs-materialso the transition is quite smooth.This is work in progress
Internal
markdown_includewithsnippetsas the former did not work well with zensical (adapts Add deprecation notice to OpenVPN pages [v6] #1029)zensical.tomlclassicvsmodern)External
git-revision-date-localized-pluginis still needed, Trackersearch.suggestandsearch.share--strictis missing, affecting link validationnot_in_nav, TrackerBy submitting this pull request, I confirm the following:
git rebase)