Skip to content

Update dnscrypt-proxy.md - Use Systemd override file instead of editi…#1343

Merged
yubiuser merged 6 commits intopi-hole:masterfrom
EyBmY:master
Feb 16, 2026
Merged

Update dnscrypt-proxy.md - Use Systemd override file instead of editi…#1343
yubiuser merged 6 commits intopi-hole:masterfrom
EyBmY:master

Conversation

@EyBmY
Copy link
Contributor

@EyBmY EyBmY commented Feb 10, 2026

…ng "/usr/lib/systemd/system/dnscrypt-proxy.socket" directly

We should not tell the user to edit "/usr/lib/systemd/system/dnscrypt-proxy.socket" directly as this directory has the lowest priority inside the Systemd realm and if DNSCrypt receives an update that also affects its Systemd unit files, the user config will get overwritten by the update. We should tell the user to use Systemd override files that take highest priority and will not get overwritten by any package updates.

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@EyBmY EyBmY requested a review from a team as a code owner February 10, 2026 01:10
@netlify
Copy link

netlify bot commented Feb 14, 2026

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 9c1cf8c
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/6992c4a53284220008f11647
😎 Deploy Preview https://deploy-preview-1343--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdwebdesign rdwebdesign dismissed a stale review February 15, 2026 03:39

Wrong button...

It should be a change request.

@rdwebdesign rdwebdesign requested a review from yubiuser February 16, 2026 02:54
EyBmY and others added 6 commits February 16, 2026 08:17
…ng "/usr/lib/systemd/system/dnscrypt-proxy.socket" directly

We should not tell the user to edit "/usr/lib/systemd/system/dnscrypt-proxy.socket" directly as this directory has the lowest priority inside the Systemd realm and if DNSCrypt receives an update that also affects its Systemd unit files, the user config will get overwritten by the update. We should tell the user to use Systemd override files that take highest priority and will not get overwritten by any package updates.

Signed-off-by: EyBmY <fabian1990@e-mail.de>
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: EyBmY <fabian1990@e-mail.de>
Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: EyBmY <fabian1990@e-mail.de>
Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: EyBmY <fabian1990@e-mail.de>
Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: EyBmY <fabian1990@e-mail.de>
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: EyBmY <fabian1990@e-mail.de>
@yubiuser yubiuser enabled auto-merge February 16, 2026 07:18
@yubiuser yubiuser disabled auto-merge February 16, 2026 07:20
@yubiuser yubiuser dismissed rdwebdesign’s stale review February 16, 2026 07:20

Requested changes have been implemented

@yubiuser yubiuser merged commit aeab0a2 into pi-hole:master Feb 16, 2026
9 checks passed
@EyBmY
Copy link
Contributor Author

EyBmY commented Feb 16, 2026

Thank you for your help, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants