Skip to content

Fix response code for session deletion#1346

Merged
yubiuser merged 1 commit intomasterfrom
fix/session_delete_response_code
Feb 14, 2026
Merged

Fix response code for session deletion#1346
yubiuser merged 1 commit intomasterfrom
fix/session_delete_response_code

Conversation

@rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Feb 12, 2026 •
edited
Loading

What does this PR aim to accomplish?

The correct response code is: 204 - No content.

The previous code (410) was removed by pi-hole/FTL#1836.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team as a code owner February 12, 2026 20:17
@netlify
Copy link

netlify bot commented Feb 13, 2026 •
edited
Loading

✅ Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 3ca75e7
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/6990b1c633bbde000899214d
😎 Deploy Preview https://deploy-preview-1346--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yubiuser
Copy link
Member

yubiuser commented Feb 14, 2026

I think the second commit can be omitted now that the change was implemented in a separate PR

@rdwebdesign
Copy link
Member Author

rdwebdesign commented Feb 14, 2026

Oh, yeah... the second commit was just a test, but I forgot to remove it.

@rdwebdesign rdwebdesign force-pushed the fix/session_delete_response_code branch from a18e3cf to b8467b6 Compare February 14, 2026 17:32
@rdwebdesign
Fix response code for session deletion
3ca75e7 
The correct is 204 - No content.

The previous code (410) is not even on the specification file: https://github.com/pi-hole/FTL/blob/8d1add8d99d8a36ccc6fb97628a33a219cf8abbd/src/api/docs/content/specs/auth.yaml#L140-L156

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the fix/session_delete_response_code branch from b8467b6 to 3ca75e7 Compare February 14, 2026 17:32
@rdwebdesign
Copy link
Member Author

rdwebdesign commented Feb 14, 2026

Done.

@rdwebdesign rdwebdesign requested a review from yubiuser February 14, 2026 17:41
@yubiuser yubiuser merged commit 02f3ccd into master Feb 14, 2026
13 checks passed
@yubiuser yubiuser deleted the fix/session_delete_response_code branch February 14, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdwebdesign @yubiuser