Conversation
UlisesGascon
requested changes
Jul 24, 2025
Author
|
Workflow added from #4 as requested @UlisesGascon 🚀 , could you approve the run of the job? Thanks! |
HISTORY.md
Outdated
Comment on lines
5
to
8
| - devdeps: eslint@^9.31.0 | ||
| - devdeps: eslint-plugin-import@2.32.0 | ||
| - devdeps: eslint-plugin-markdown@^5.1.0 | ||
| - devdeps: mocha@^11.7. |
Member
There was a problem hiding this comment.
Suggested change
| - devdeps: eslint@^9.31.0 | |
| - devdeps: eslint-plugin-import@2.32.0 | |
| - devdeps: eslint-plugin-markdown@^5.1.0 | |
| - devdeps: mocha@^11.7. |
In the History we focus only in prod ones 👍
HISTORY.md
Outdated
| - deps: setprototypeof@1.0.3 | ||
|
|
||
| * deps: path-is-absolute@1.0.1 | ||
| # 1.3.3 / 2016-11-14 |
Member
There was a problem hiding this comment.
No need to change the headers, we used this legacy format as some people are scrapping this info
Author
There was a problem hiding this comment.
ouch sorry for this, it was my local prettier
| shell: bash | ||
| run: sudo apt-get -y install lcov | ||
| - name: Collect coverage reports | ||
| uses: actions/download-artifact@v3 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/download-artifact@v3 | |
| uses: actions/download-artifact@v4 |
I think that this will solve the CI issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to update the dependencies so they are up to date and do not have any vulnerabilities.
It is my first time committing to this repo, please do tell me if there is some other procedure I should follow to merge it.
Resolves #6