Conversation
|
Does the contents of the README really need to be replicated into the type definitions? Any way we can add a check to CI to prevent us from letting it get out of sync on accident if we have to do this? |
| */ | ||
| declare function resolvePath(rootPath: string, relativePath: string): string; | ||
|
|
||
| declare namespace resolvePath { |
There was a problem hiding this comment.
What does this do? Sorry not familiar with typings.
There was a problem hiding this comment.
Right, but I mean what exactly does an empty namespace so for typescript?
There was a problem hiding this comment.
Removing the empty namespace will raise a type-check error in older version. It seems useless for current version. See the issue microsoft/TypeScript#5073
There was a problem hiding this comment.
Ah, gotcha. I would have never known that, thank you. I would have accepted someone's PR removing it by accident. Can we add a test for this to prevent accidental removal?
There was a problem hiding this comment.
Idk, I'm not familiar with typescript. That's why I'm asking you :) if you're not sure, do you know someone who may be who van come and help out here?
There was a problem hiding this comment.
https://github.com/baryon/tracer
https://github.com/Microsoft/dtslint
found an example
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Add a CI task to validate comments in typings are in sync with readme or remove readme copy from typings.
include the typings
2 participants
No description provided.