Refactor SendStream to an ES6 class#244
Open
Phillip9587 wants to merge 1 commit intopillarjs:masterfrom
Open
Conversation
wesleytodd
reviewed
Jan 23, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
I am generally 👍 on this. I want to spend a bit more time going through it in detail before I drop a ✅ since it is such a large change set.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var self = this | ||
|
|
||
| debug('stat "%s"', path) | ||
| fs.stat(path, function onstat (err, stat) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| var p = path + '.' + self._extensions[i++] | ||
|
|
||
| debug('stat "%s"', p) | ||
| fs.stat(p, function (err, stat) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| var p = join(path, self._index[i]) | ||
|
|
||
| debug('stat "%s"', p) | ||
| fs.stat(p, function (err, stat) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| this.stream(path, opts) | ||
| } | ||
| // pipe | ||
| var stream = fs.createReadStream(path, options) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
SendStreamto an ES6 class, improving code organization, readability, and alignment with modern JavaScript practices. The functionality remains unchanged.