Map json nulls and optional fields to Option type #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new operators to reach inside nested json paths More syntactic sugar and docs Try to introduce Span<T> first pass
Owner
|
Hi! Thanks for your work on this. I think the custom operators are also a nice touch, though you need to add examples in the docs before we can roll this in. I also appreciate the splitting up of the tests. Good call. I'd kindly ask you to roll back that running of fantomas. Aside from the core serializer, which is borrowed from Microsoft (as denoted by the comments), the F# was formatted how I prefer it. So let's make that fix before we dig any deeper into this. |
Owner
|
How are things going on this? |
Contributor
|
I was going to say that the extra operators seem nice and the span stuff might be interesting, not sure how much effort it'll take to disentangle the multiple different changes and the formatting into separate changes though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pimbrouwers Thanks for sharing this project.
Open to your comments.
Sorry I had to run the latest fantomas code formatter across the whole project.
I'm not a big fan of the formatter but it was too painful without it.