Open
Conversation
Add Stop button
stop button added
Codecov Report
@@ Coverage Diff @@
## develop #279 +/- ##
===========================================
+ Coverage 95.89% 96.90% +1.01%
===========================================
Files 2 3 +1
Lines 73 97 +24
===========================================
+ Hits 70 94 +24
Misses 3 3
Continue to review full report at Codecov.
|
djmattyg007
reviewed
Apr 6, 2021
hard tab replaced by soft tabs
Hard tab replaced with softtab
shameerariff
commented
Apr 10, 2021
Author
shameerariff
left a comment
shameerariff
left a comment
There was a problem hiding this comment.
Hard tabs are replaced with soft tabs
djmattyg007
suggested changes
Apr 24, 2021
Comment on lines
+531
to
+532
| toast('Stopping current track...') | ||
| mopidy.playback.stop() |
There was a problem hiding this comment.
The indentation on this line doesn't match the indentation in other functions on either side of this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added the stop button, probably it need testing as I do not have all the services installed in my env.