Conversation
Add byte-level progress bars to file downloads in CacheManager. Shows download speed, ETA, and bytes transferred with proper handling of resumed downloads. - Import tqdm in cache.py - Wrap download loop with tqdm progress bar - Display file size, download speed, and ETA - Show already-downloaded bytes when resuming - All existing tests pass (190/190) Related to SDK-321 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When loading datasets from cloud storage, users see no feedback during downloads. For large datasets, this creates a poor experience as users don't know if the download is progressing, stalled, or how long it will take.
Solution
Added byte-level progress bars to dataset downloads using tqdm. The progress bar shows:
Changes
pinecone_datasets/cache.py:_download_filemethod with tqdm progress barTesting
Example Output
When resuming an interrupted download:
Related
Made with Cursor
Note
Low Risk
Low risk: changes are limited to wrapping file downloads with a
tqdmprogress bar; primary risk is minor output/TTY compatibility or overhead during downloads.Overview
Adds byte-level download progress feedback to cached dataset downloads by wrapping
CacheManager._download_filewith atqdmprogress bar.The progress bar is initialized with the remote file size and resume offset (
initial=start_byte), updates on each chunk written, and displays the filename in the description while keeping existing resumable/metadata behavior intact.Written by Cursor Bugbot for commit f040bab. This will update automatically on new commits. Configure here.