*: add materialized view DDL syntax by wjhuang2016 · Pull Request #66022 · pingcap/tidb

wjhuang2016 · 2026-02-04T07:05:27Z

What problem does this PR solve?

Issue Number: ref #65936 ref #18023

Problem Summary:

The original PR (*: add MV systables + MV/MLOG DDL metadata (scheme2) #65936) is too large to review/merge efficiently. This PR extracts the SQL syntax + AST + planner preprocessing/privilege wiring for Materialized View and Materialized View Log to reduce the review surface area of follow-up executor/infoschema/bootstrap changes.

What changed and how does it work?

Parser: add MV/MV LOG/REFRESH related syntax, keywords and AST nodes (includes parser.go regeneration).
Planner: extend preprocess/visitInfo to avoid resolving MV names as normal tables during preprocessing.

Note: This PR only introduces syntax and frontend wiring; executor/DDL implementations will come in follow-up PRs.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

wjhuang2016 · 2026-02-04T07:05:37Z

Tests:

go test -C pkg/parser ./...

codecov · 2026-02-04T07:24:11Z

Codecov Report

❌ Patch coverage is 44.44444% with 275 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/release-8.5-materialized-view@f3af7d5). Learn more about missing BASE report.

Additional details and impacted files

@@                            Coverage Diff                             @@
##             feature/release-8.5-materialized-view     #66022   +/-   ##
==========================================================================
  Coverage                                         ?   57.0830%           
==========================================================================
  Files                                            ?       1784           
  Lines                                            ?     638126           
  Branches                                         ?          0           
==========================================================================
  Hits                                             ?     364262           
  Misses                                           ?     249394           
  Partials                                         ?      24470

Flag	Coverage Δ
integration	`37.0423% <0.0000%> (?)`
unit	`72.6667% <44.4444%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9278% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`52.7388% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Drop unused MV keywords (INCLUDING/NEW/DEMAND) - Align CREATE MV refresh on-clause to [START WITH] NEXT - Add COMPLETE refresh type - Support TIFLASH REPLICA for MV LOG + ALTER actions - Extend ALTER MV LOG purge syntax + tests

wjhuang2016 · 2026-02-04T14:46:43Z

/retest

wjhuang2016 · 2026-02-04T15:08:45Z

/retest

fzzf678 · 2026-02-05T03:38:10Z

pkg/planner/core/preprocess.go

 		p.checkCreateViewGrammar(node)
 		p.checkCreateViewWithSelectGrammar(node)


Shall we also add these check for mv?

No, MV is not view

fzzf678 · 2026-02-05T03:42:12Z

pkg/planner/core/planbuilder.go

 	case *ast.CreateResourceGroupStmt, *ast.DropResourceGroupStmt, *ast.AlterResourceGroupStmt:
 		err := plannererrors.ErrSpecificAccessDenied.GenWithStackByArgs("SUPER or RESOURCE_GROUP_ADMIN")
 		b.visitInfo = appendDynamicVisitInfo(b.visitInfo, []string{"RESOURCE_GROUP_ADMIN"}, false, err)
+	case *ast.CreateMaterializedViewStmt:


These case branch has some common logic, better to extract some functions to call.

fzzf678 · 2026-02-05T03:52:04Z

pkg/parser/parser.y

+	}
+
+CreateMaterializedViewLogStmt:
+	"CREATE" "MATERIALIZED" "VIEW" "LOG" "ON" TableName '(' ColumnList ')' MLogOptionClauseOpt MLogPurgeClauseOpt


Currently, MLogOptionClauseOpt must be placed beforeMLogPurgeClauseOpt, reverse order is not supported. If we want a flexible order, this needs to be adjusted.

We don't support the reverse order

…ed-view' into mv/scheme2-split-pr1-parser

windtalker

lgtm

ti-chi-bot · 2026-02-06T03:02:01Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fzzf678, windtalker
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft, elsa0520, tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

pkg/parser/OWNERS
pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-02-06T03:02:06Z

[LGTM Timeline notifier]

Timeline:

2026-02-06 02:46:04.120485885 +0000 UTC m=+407835.221884604: ☑️ agreed by fzzf678.
2026-02-06 03:02:04.983287972 +0000 UTC m=+408796.084686692: ☑️ agreed by windtalker.

wjhuang2016 · 2026-02-06T03:05:00Z

/retest

wjhuang2016 · 2026-02-06T03:16:48Z

/retest

wjhuang2016 · 2026-02-06T03:49:45Z

/retest

*: add materialized view DDL syntax (parser/planner)

c380c11

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner labels Feb 4, 2026

wjhuang2016 added the component/parser label Feb 4, 2026

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 4, 2026

wjhuang2016 added 3 commits February 4, 2026 16:01

parser: only support REFRESH MATERIALIZED VIEW FAST

2e941af

parser: align MV DDL grammar with Stage-1 spec

f38572f

- Drop unused MV keywords (INCLUDING/NEW/DEMAND) - Align CREATE MV refresh on-clause to [START WITH] NEXT - Add COMPLETE refresh type - Support TIFLASH REPLICA for MV LOG + ALTER actions - Extend ALTER MV LOG purge syntax + tests

parser: fix MV restore and add missing tests

1040fb9

fzzf678 reviewed Feb 5, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/feature/release-8.5-materializ…

8f99b43

…ed-view' into mv/scheme2-split-pr1-parser

wjhuang2016 mentioned this pull request Feb 5, 2026

executor: support CREATE MATERIALIZED VIEW LOG #66080

Merged

12 tasks

wjhuang2016 added 2 commits February 5, 2026 22:40

parser: drop TiFlash replica for MV

b643fc0

parser: drop TiFlash replica for MLOG

df53edd

fzzf678 approved these changes Feb 6, 2026

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 6, 2026

windtalker approved these changes Feb 6, 2026

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2026

ti-chi-bot added the approved label Feb 6, 2026

ti-chi-bot bot merged commit 96a16b2 into pingcap:feature/release-8.5-materialized-view Feb 6, 2026
19 checks passed

		p.checkCreateViewGrammar(node)
		p.checkCreateViewWithSelectGrammar(node)

Conversation

wjhuang2016 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

wjhuang2016 commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wjhuang2016 commented Feb 4, 2026

Uh oh!

wjhuang2016 commented Feb 4, 2026

Uh oh!

fzzf678 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

wjhuang2016 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

fzzf678 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fzzf678 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wjhuang2016 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Feb 6, 2026

Uh oh!

ti-chi-bot bot commented Feb 6, 2026

[LGTM Timeline notifier]

Uh oh!

wjhuang2016 commented Feb 6, 2026

Uh oh!

wjhuang2016 commented Feb 6, 2026

Uh oh!

wjhuang2016 commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wjhuang2016 commented Feb 4, 2026 •

edited

Loading

codecov bot commented Feb 4, 2026 •

edited

Loading

fzzf678 Feb 5, 2026 •

edited

Loading

fzzf678 Feb 5, 2026 •

edited

Loading