Skip to content

expression: add masking builtins#66038

Open
tiancaiamao wants to merge 8 commits intopingcap:masterfrom
tiancaiamao:pr/phase9-builtins
Open

expression: add masking builtins#66038
tiancaiamao wants to merge 8 commits intopingcap:masterfrom
tiancaiamao:pr/phase9-builtins

Conversation

@tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #65744

Problem Summary:

  • add MASK_FULL / MASK_PARTIAL / MASK_NULL / MASK_DATE builtins

What changed and how does it work?

  • implement masking builtins with type-aware behavior and collation-aware slicing
  • add unit tests and integration tests for masking functions

Tests:

  • make failpoint-enable && (cd pkg/expression && go test -tags intest -run TestMask; rc=$?; cd - >/dev/null; make failpoint-disable; exit $rc)
  • cd tests/integrationtest; ./run-tests.sh -s ../../bin/tidb-server -r expression/builtin

Stacked PRs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter, guo-shaoge, xuhuaiyu, yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link

tiprow bot commented Feb 4, 2026

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 4, 2026

@tiancaiamao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lightning-integration-test 2432af0 link true /test pull-lightning-integration-test
pull-integration-realcluster-test-next-gen 2432af0 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 2432af0 link true /test pull-unit-test-next-gen
pull-build-next-gen 2432af0 link true /test pull-build-next-gen
idc-jenkins-ci-tidb/check_dev 2432af0 link true /test check-dev
idc-jenkins-ci-tidb/build 2432af0 link true /test build
pull-mysql-client-test 2432af0 link true /test pull-mysql-client-test
pull-unit-test-ddlv1 2432af0 link true /test pull-unit-test-ddlv1
pull-mysql-client-test-next-gen 2432af0 link true /test pull-mysql-client-test-next-gen
pull-br-integration-test 2432af0 link true /test pull-br-integration-test
pull-integration-e2e-test 2432af0 link true /test pull-integration-e2e-test
idc-jenkins-ci-tidb/mysql-test 2432af0 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 2432af0 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 2432af0 link true /test check-dev2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant