Makefile: add command to lint changed files not the whole pkg#66117
Makefile: add command to lint changed files not the whole pkg#66117ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #66117 +/- ##
================================================
- Coverage 77.7818% 77.5074% -0.2745%
================================================
Files 2001 1924 -77
Lines 545618 541596 -4022
================================================
- Hits 424392 419777 -4615
- Misses 119564 121797 +2233
+ Partials 1662 22 -1640
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
As a comparison, in my local env(ryzen 9950x), change some files in optimizer and make sure that
|
|
/hold for a while |
|
/retest |
|
This PR adds make bazel_lint_changed, which builds (with nogo) only the Bazel packages detected as changed vs an auto-detected base ref (build/ Main review concerns (likely correctness/coverage gaps):
Suggested fixes (implementation up to the author):
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/unhold |
|
/retest |
|
@winoros: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #66115
Problem Summary:
What changed and how does it work?
This pr doesn't intend to improve the CI efficiency.
As the first step, it focuses on improving the local workflow for developers and agents.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.