Skip to content

planner/test: make reports replay deterministic with repo testdata#66121

Closed
hawkingrei wants to merge 1 commit intopingcap:masterfrom
hawkingrei:pr-66107-reports-deterministic
Closed

planner/test: make reports replay deterministic with repo testdata#66121
hawkingrei wants to merge 1 commit intopingcap:masterfrom
hawkingrei:pr-66107-reports-deterministic

Conversation

@hawkingrei
Copy link
Member

What problem does this PR solve?

Issue Number: close #66107

Problem Summary:
The reports replay test currently depends on local ad-hoc reports/ files and can become a no-op in CI/dev environments.

What changed and how does it work?

  • Add deterministic reports replay test: pkg/planner/core/casetest/join/reports_test.go.
  • Add repository-managed testdata under pkg/planner/core/casetest/join/testdata/reports/case_65454/.
  • Update pkg/planner/core/casetest/join/BUILD.bazel to include reports_test.go.
  • The test now reads testdata/reports/case_*/summary.json instead of external local reports/ directories.

Dependency note:

  • This PR contains a regression repro case and is expected to be merged after the join-reorder fix PR (#66116).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test scripts:

  • go test -run TestReportsCantFindColumn --tags=intest ./pkg/planner/core/casetest/join -count=1

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed labels Feb 6, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terry1purcell for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Feb 6, 2026
@tiprow
Copy link

tiprow bot commented Feb 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2026
@hawkingrei
Copy link
Member Author

Superseded by #66116. Per reviewer preference, test changes are folded into the main fix PR instead of staying in a separate test-only PR.

@hawkingrei hawkingrei closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

planner-test: make reports-based Can't find column regressions deterministic

1 participant