planner/test: make reports replay deterministic with repo testdata#66121
planner/test: make reports replay deterministic with repo testdata#66121hawkingrei wants to merge 1 commit intopingcap:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
|
Superseded by #66116. Per reviewer preference, test changes are folded into the main fix PR instead of staying in a separate test-only PR. |
What problem does this PR solve?
Issue Number: close #66107
Problem Summary:
The reports replay test currently depends on local ad-hoc
reports/files and can become a no-op in CI/dev environments.What changed and how does it work?
pkg/planner/core/casetest/join/reports_test.go.pkg/planner/core/casetest/join/testdata/reports/case_65454/.pkg/planner/core/casetest/join/BUILD.bazelto includereports_test.go.testdata/reports/case_*/summary.jsoninstead of external localreports/directories.Dependency note:
#66116).Check List
Tests
Manual test scripts:
go test -run TestReportsCantFindColumn --tags=intest ./pkg/planner/core/casetest/join -count=1Side effects
Documentation
Release note