Skip to content

pingone_davinci_flow_deploy and pingone_davinci_flow_enabled beta resources#1177

Merged
henryrecker-pingidentity merged 279 commits intomainfrom
DVFlowEnabledAndDeploy
Jan 29, 2026
Merged

pingone_davinci_flow_deploy and pingone_davinci_flow_enabled beta resources#1177
henryrecker-pingidentity merged 279 commits intomainfrom
DVFlowEnabledAndDeploy

Conversation

@henryrecker-pingidentity
Copy link
Contributor

@henryrecker-pingidentity henryrecker-pingidentity commented Dec 4, 2025

Change Description

  • Add pingone_davinci_flow_deploy resource
  • Add pingone_davinci_flow_enabled resource to control enabling and disabling flows
  • Remove inaccurate string length validators on the pingone_davinci_flow resource
  • Workaround API not allowing setting DV variables to false

Change Characteristics

  • This PR contains beta functionality
  • This PR requires introduction of breaking changes
  • No changelog entry is needed

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

  • Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
    • The changelog entry has been included according to the changelog process
    • Changes have proper test coverage (including regression tests)
    • Impacted resource, data source and schema descriptions have been reviewed and updated
    • Impacted resource and data source documentation HCL examples have been reviewed and updated
    • Does not introduce breaking changes (unless required to do so)
    • I am aware that changes to generated code may not be merged

Required SDK Upgrades

Testing

This PR has been tested with:

  • Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)

Shell Command(s)

TF_ACC=1 TESTACC_BETA=true go test -tags=beta -v -timeout 900s -run ^TestAccDavinciFlowDeploy github.com/pingidentity/terraform-provider-pingone/internal/service/davinci
TF_ACC=1 TESTACC_BETA=true go test -tags=beta -v -timeout 900s -run ^TestAccDavinciFlowEnable github.com/pingidentity/terraform-provider-pingone/internal/service/davinci

Testing Results

Currently the broken deploy tests are failing due to a client issue - will be fixed by pingidentity/pingone-go-client#54. I pasted the local run of the enabled tests below, and will rely on the end-to-end tests linked below for the deploy test results, since they can take a long time to run due to the retries.

Expand Results
=== RUN   TestAccDavinciFlowEnabled_RemovalDrift
=== PAUSE TestAccDavinciFlowEnabled_RemovalDrift
=== RUN   TestAccDavinciFlowEnabled_MinimalMaximalClean
=== PAUSE TestAccDavinciFlowEnabled_MinimalMaximalClean
=== RUN   TestAccDavinciFlowEnabled_MinimalMaximalWithBootstrap
=== PAUSE TestAccDavinciFlowEnabled_MinimalMaximalWithBootstrap
=== RUN   TestAccDavinciFlowEnabled_NewEnv
=== PAUSE TestAccDavinciFlowEnabled_NewEnv
=== RUN   TestAccDavinciFlowEnabled_BadParameters
=== PAUSE TestAccDavinciFlowEnabled_BadParameters
=== CONT  TestAccDavinciFlowEnabled_RemovalDrift
=== CONT  TestAccDavinciFlowEnabled_MinimalMaximalWithBootstrap
=== CONT  TestAccDavinciFlowEnabled_NewEnv
=== CONT  TestAccDavinciFlowEnabled_BadParameters
=== CONT  TestAccDavinciFlowEnabled_MinimalMaximalClean
--- PASS: TestAccDavinciFlowEnabled_BadParameters (9.93s)
--- PASS: TestAccDavinciFlowEnabled_MinimalMaximalClean (24.35s)
--- PASS: TestAccDavinciFlowEnabled_MinimalMaximalWithBootstrap (28.00s)
--- PASS: TestAccDavinciFlowEnabled_NewEnv (41.76s)
--- PASS: TestAccDavinciFlowEnabled_RemovalDrift (77.95s)
PASS
ok  	github.com/pingidentity/terraform-provider-pingone/internal/service/davinci	78.469s

End-to-end Tests Workflow Links

Base automatically changed from GeneratedDVFlowWithDraftClient to main January 29, 2026 20:18
@henryrecker-pingidentity henryrecker-pingidentity changed the base branch from main to GeneratedDVFlowWithDraftClient January 29, 2026 20:28
@henryrecker-pingidentity henryrecker-pingidentity changed the base branch from GeneratedDVFlowWithDraftClient to main January 29, 2026 20:41
@henryrecker-pingidentity henryrecker-pingidentity merged commit ac38819 into main Jan 29, 2026
29 of 33 checks passed
@henryrecker-pingidentity henryrecker-pingidentity deleted the DVFlowEnabledAndDeploy branch January 29, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants