Skip to content

Permit unexpected properties in Davinci flow node properties with warning rather than error#1203

Merged
henryrecker-pingidentity merged 8 commits intomainfrom
DVFlowNodePropertiesSoftSchema
Feb 13, 2026
Merged

Permit unexpected properties in Davinci flow node properties with warning rather than error#1203
henryrecker-pingidentity merged 8 commits intomainfrom
DVFlowNodePropertiesSoftSchema

Conversation

@henryrecker-pingidentity
Copy link
Contributor

@henryrecker-pingidentity henryrecker-pingidentity commented Feb 2, 2026

Change Description

  • Update state logic for the data.properties field for nodes in a DaVinci flow. The logic will now only warn for any fields that are newly returned from the API, rather than causing a plan or an inconsistent value error.
  • Existing fields can be edited or removed as normal from the terraform config
  • Terraform will detect drift on any properties fields defined in the terraform config as normal
  • Test via direct API calls to simulate backend changes
  • Jira: CDI-704

Change Characteristics

  • This PR contains beta functionality
  • This PR requires introduction of breaking changes
  • No changelog entry is needed

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

  • Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
    • The changelog entry has been included according to the changelog process
    • Changes have proper test coverage (including regression tests)
    • Impacted resource, data source and schema descriptions have been reviewed and updated
    • Impacted resource and data source documentation HCL examples have been reviewed and updated
    • Does not introduce breaking changes (unless required to do so)
    • I am aware that changes to generated code may not be merged

Required SDK Upgrades

Testing

This PR has been tested with:

  • Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)

Shell Command(s)

Testing Results

Expand Results

End-to-end Tests Workflow Links

@henryrecker-pingidentity
Copy link
Contributor Author

Some notes that I'm interested in feedback on:

  • I considered but did not add a read-only field which would hold the full API response for data.properties (such as a data.properties_all field for example). It wasn't clear to me whether this would actually be useful, so I ended up leaving it out.
  • I also considered a provider-level toggle for this behavior - a boolean that would force the typical more strict terraform handling of this attribute. But again it wasn't clear to me that this would be useful, and I thought it would potentially cause more confusion than it is worth, so I left it out.
  • The acceptance test I added has to do some manual API timestamp validation because I ran into a test framework issue that I couldn't figure out - see Refresh test step passes regardless of whether ExpectNonEmptyPlan is true or false hashicorp/terraform-plugin-testing#599

@henryrecker-pingidentity henryrecker-pingidentity changed the title Permit unexpected properties in Davinci flow node properties with warning rather than error CDI-704: Permit unexpected properties in Davinci flow node properties with warning rather than error Feb 2, 2026
@henryrecker-pingidentity henryrecker-pingidentity changed the title CDI-704: Permit unexpected properties in Davinci flow node properties with warning rather than error Permit unexpected properties in Davinci flow node properties with warning rather than error Feb 2, 2026
@henryrecker-pingidentity henryrecker-pingidentity marked this pull request as ready for review February 2, 2026 18:25
@henryrecker-pingidentity henryrecker-pingidentity requested a review from a team as a code owner February 2, 2026 18:25
Copy link
Collaborator

@patrickcping patrickcping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I missed this until now. LGTM 🚀 🚀

@henryrecker-pingidentity henryrecker-pingidentity merged commit 3214a2c into main Feb 13, 2026
29 of 33 checks passed
@henryrecker-pingidentity henryrecker-pingidentity deleted the DVFlowNodePropertiesSoftSchema branch February 13, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants