Dynamic load detectors and transformers #1652
Open
+47
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbh123456
force-pushed
the
bohao/detector_fix
branch
2 times, most recently
from
7de60ff to
7b12c03
Compare
wbh123456
force-pushed
the
bohao/detector_fix
branch
from
7b12c03 to
6a4ffef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored both
detector.tsandtransformer.tsxto fix a race condition where custom column detectors and transformers (loaded viawindow.CUSTOM_COLUMN_DETECTORSandwindow.CUSTOM_COLUMN_TRANSFORMERS) were not being applied if the custom script loaded after the main bundle.The application now fetches the latest custom configurations every time it processes a table or requests transformers, ensuring that asynchronously loaded plugins are correctly registered and used.
Test:
Tested in devapp.
image_signature is now successfully loading with the proper transformer.
Jira:
https://pinterest.atlassian.net/browse/AP-5568