Skip to content

Comments

Few fixes for Header.Unmarshal#328

Merged
sirzooro merged 1 commit intopion:masterfrom
sirzooro:rtp_unmarshal_fixes
Oct 5, 2025
Merged

Few fixes for Header.Unmarshal#328
sirzooro merged 1 commit intopion:masterfrom
sirzooro:rtp_unmarshal_fixes

Conversation

@sirzooro
Copy link
Contributor

@sirzooro sirzooro commented Oct 5, 2025

  • Skip one-byte padding with non-zero length as specified in RFC;
  • Return proper header length when one-byte extension with ID=15 or one-byte padding with non-zero length was found;
  • fixed check for end of extended header payloads;

@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.03%. Comparing base (f6b0da1) to head (1b9adde).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packet.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   87.11%   87.03%   -0.09%     
==========================================
  Files          26       26              
  Lines        3182     3185       +3     
==========================================
  Hits         2772     2772              
- Misses        350      352       +2     
- Partials       60       61       +1     
Flag Coverage Δ
go 87.03% <80.00%> (-0.09%) ⬇️
wasm 86.49% <80.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Skip one-byte padding with non-zero length as specified in RFC;
- Return proper header length when one-byte extension with ID=15 or
  one-byte padding with non-zero length was found;
- fixed check for end of extended header payloads;
@sirzooro sirzooro force-pushed the rtp_unmarshal_fixes branch from c575d17 to 1b9adde Compare October 5, 2025 14:19
@sirzooro sirzooro requested review from JoTurk and at-wat October 5, 2025 14:24
Copy link
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sirzooro sirzooro merged commit ece8be3 into pion:master Oct 5, 2025
16 checks passed
@sirzooro sirzooro deleted the rtp_unmarshal_fixes branch October 5, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants