Skip to content

Findperson - New scenarios and some tests to give variation to the strings#6251

Open
zonkmachine wants to merge 4 commits intopioneerspacesim:masterfrom
zonkmachine:findperson
Open

Findperson - New scenarios and some tests to give variation to the strings#6251
zonkmachine wants to merge 4 commits intopioneerspacesim:masterfrom
zonkmachine:findperson

Conversation

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Nov 17, 2025

Addresses #6249 (Find person)

  • Use different name forms in the risk messages for some variation. First name/Surname/Full name.
  • Adds character roles. i.e. Instead of 'a family member', use cousin, step brother, uncle, etc.
  • Adds more missions - 8 new scenarios (introtexts) for a total of 20.

The character roles are maybe a lot of lines but they are really easy to come up with and should be equally easy to translate.

  • The name variations, if wanted, should probably be a member function in 'Character'.
  • They should be a separate file in data/lang/ much like the ships.
  • The lists are currently inconsistent in that the employees and friends are in their indefinite form, but the realtives are in their base form. Maybe treat them fully like the ships with base, definitive, and indefinite forms?
  • They are enummerated but should perhaps be named by their actual word.
    EMPLOYEE_MALE_7 -> EMPLOYEE_MALE_MANAGER

@zonkmachine
Copy link
Member Author

  • Fix: Hyphenate brother in law/sister in law
  • Character/Method - Instead of function randName in FindPerson.lua, create a member function in libs/Character.lua that returns one of name/surname/firstname. firstname is only an option if argument 'informal' is set to 'true'. The name returned is selected from the ascii value of the characters name.

@zonkmachine zonkmachine force-pushed the findperson branch 3 times, most recently from acaa9c6 to 02153fe Compare November 19, 2025 06:24
@zonkmachine
Copy link
Member Author

  • Character/Method - Instead of function randName in FindPerson.lua, create a member function in libs/Character.lua that returns one of name/surname/firstname. firstname is only an option if argument 'informal' is set to 'true'. The name returned is selected from the ascii value of the characters name.

I removed these changes as it got too complicated. The change for variation is now a one liner. The name of {wanted} in the risk message is now hard coded to surname. This gives enough variation.

@zonkmachine
Copy link
Member Author

zonkmachine commented Jan 10, 2026

  • The name variations, if wanted, should probably be a member function in 'Character'.
  • They should be a separate file in data/lang/ much like the ships.

I looked at putting roles, employee/friend/family, in a separate file but it just made it much more difficult to work with in the modules. Also, family and employee/friends and family, are different grammatically. This works for me now.

Code has been rebased on latest master.

@zonkmachine zonkmachine marked this pull request as ready for review January 11, 2026 07:22
Copy link
Member

@sturnclaw sturnclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few strings changes are required. Otherwise, this looks like a good expansion of the flavor available in this mission type.

},
"INTROTEXT_EVACUATION_FEMALE_3": {
"description": "",
"message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details but she's informed us that she's in danger and we have no reason to question this. Her name is {wanted} and she's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I can't go into greater details"

This part is fine,

"but she's informed us she's in danger and we have no reason to question that"

This is very shaky justification for someone to spend ~$10k-$100k USD to hire what is effectively a private investigator / PMC to extract the person in question. I'd recommend something like:

Suggested change
"message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details but she's informed us that she's in danger and we have no reason to question this. Her name is {wanted} and she's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system."
"message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details due to security concerns, but there is a credible threat to her safety. She has gone into hiding at one of the spaceports in the system, but she was unable to safely tell us which one. Her name is {wanted} and she's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system."

Technically this reads much like the following introtext, but it provides a good justification for why this company doesn't know where their employee has been assigned to.

},
"INTROTEXT_EVACUATION_MALE_3": {
"description": "",
"message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details but he's informed us that he is in danger and we have no reason to question this. His name is {wanted} and he's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for the male version of the text.

},
"INTROTEXT_PRIVATEER_FEMALE_3": {
"description": "",
"message": "Hi there! My name is {client} and I need help to get a message throught to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. She flies missions there and her ship has registration id {shipid}. I will pay you {cash} upon returning to {domicile} with an answer."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"message": "Hi there! My name is {client} and I need help to get a message throught to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. She flies missions there and her ship has registration id {shipid}. I will pay you {cash} upon returning to {domicile} with an answer."
"message": "Hi there! My name is {client} and I need help to get a message through to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. She flies missions there and her ship is registered as {shipid}. I will pay you {cash} upon returning to {domicile} with an answer."

},
"INTROTEXT_PRIVATEER_MALE_3": {
"description": "",
"message": "Hi there! My name is {client} and I need help to get a message throught to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. He flies missions there and his ship has registration id {shipid}. I will pay you {cash} upon returning to {domicile} with an answer."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants