Findperson - New scenarios and some tests to give variation to the strings#6251
Findperson - New scenarios and some tests to give variation to the strings#6251zonkmachine wants to merge 4 commits intopioneerspacesim:masterfrom
Conversation
000cf93 to
26fa008
Compare
|
acaa9c6 to
02153fe
Compare
I removed these changes as it got too complicated. The change for variation is now a one liner. The name of {wanted} in the risk message is now hard coded to surname. This gives enough variation. |
02153fe to
6528c2a
Compare
6528c2a to
b33ac7c
Compare
I looked at putting roles, employee/friend/family, in a separate file but it just made it much more difficult to work with in the modules. Also, family and employee/friends and family, are different grammatically. This works for me now. Code has been rebased on latest master. |
sturnclaw
left a comment
There was a problem hiding this comment.
A few strings changes are required. Otherwise, this looks like a good expansion of the flavor available in this mission type.
| }, | ||
| "INTROTEXT_EVACUATION_FEMALE_3": { | ||
| "description": "", | ||
| "message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details but she's informed us that she's in danger and we have no reason to question this. Her name is {wanted} and she's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system." |
There was a problem hiding this comment.
"I can't go into greater details"
This part is fine,
"but she's informed us she's in danger and we have no reason to question that"
This is very shaky justification for someone to spend ~$10k-$100k USD to hire what is effectively a private investigator / PMC to extract the person in question. I'd recommend something like:
| "message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details but she's informed us that she's in danger and we have no reason to question this. Her name is {wanted} and she's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system." | |
| "message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details due to security concerns, but there is a credible threat to her safety. She has gone into hiding at one of the spaceports in the system, but she was unable to safely tell us which one. Her name is {wanted} and she's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system." |
Technically this reads much like the following introtext, but it provides a good justification for why this company doesn't know where their employee has been assigned to.
| }, | ||
| "INTROTEXT_EVACUATION_MALE_3": { | ||
| "description": "", | ||
| "message": "Hello, I'm {client}. I represent {company}. We need to get one of our employees out of the {system} system immediately. I can't go into greater details but he's informed us that he is in danger and we have no reason to question this. His name is {wanted} and he's somewhere in the {system} ({sectorx}, {sectory}, {sectorz}) system." |
There was a problem hiding this comment.
Ditto for the male version of the text.
| }, | ||
| "INTROTEXT_PRIVATEER_FEMALE_3": { | ||
| "description": "", | ||
| "message": "Hi there! My name is {client} and I need help to get a message throught to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. She flies missions there and her ship has registration id {shipid}. I will pay you {cash} upon returning to {domicile} with an answer." |
There was a problem hiding this comment.
| "message": "Hi there! My name is {client} and I need help to get a message throught to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. She flies missions there and her ship has registration id {shipid}. I will pay you {cash} upon returning to {domicile} with an answer." | |
| "message": "Hi there! My name is {client} and I need help to get a message through to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. She flies missions there and her ship is registered as {shipid}. I will pay you {cash} upon returning to {domicile} with an answer." |
| }, | ||
| "INTROTEXT_PRIVATEER_MALE_3": { | ||
| "description": "", | ||
| "message": "Hi there! My name is {client} and I need help to get a message throught to {wanted} in the {system} ({sectorx}, {sectory}, {sectorz}) system. He flies missions there and his ship has registration id {shipid}. I will pay you {cash} upon returning to {domicile} with an answer." |
Addresses #6249 (Find person)
The character roles are maybe a lot of lines but they are really easy to come up with and should be equally easy to translate.
EMPLOYEE_MALE_7 -> EMPLOYEE_MALE_MANAGER