[chore] Test showing piscina failures in Jest#966
Open
linnerissa wants to merge 7 commits intopiscinajs:currentfrom
Open
[chore] Test showing piscina failures in Jest#966linnerissa wants to merge 7 commits intopiscinajs:currentfrom
linnerissa wants to merge 7 commits intopiscinajs:currentfrom
Conversation
…ns in the library. currently fails due to object check on ready message received
…worker thread in order to succeed. similar to jest/ready-message.test.ts
metcoder95
reviewed
Feb 5, 2026
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This is super helpful
Can you just add it to the .github/workflows/node.yml as part of the CI?
Signed-off-by: Nerissa Lin <64402413+linnerissa@users.noreply.github.com>
Contributor
Author
|
@metcoder95 i added the test to this approach should be better for local - anyone running |
Member
|
Tests seems failing |
Contributor
Author
|
scripts/run-tests.js ignore parameter actually resolves diff in macos vs windows. changed approach 🙏 |
metcoder95
reviewed
Feb 6, 2026
| @@ -0,0 +1,30 @@ | |||
| import { resolve } from 'node:path'; | |||
Member
There was a problem hiding this comment.
I believe something is going wrong with the test on windows, but the output on console doesn't seem that helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest doesnt pass the onWorkerReady message check to execute work after new threads are spun up. Added Jest to show that.
package.json
native tests need to skip test/jest subdirectory
added a native version of the new jest test to explicitly force reliance on adding a new thread to pass