Conversation
crates/lib/src/config.rs
Outdated
| Ok(path) | ||
| } | ||
| } else { | ||
| let home = dirs_next::home_dir(); |
There was a problem hiding this comment.
I'd love to just move the unwrapping here, since, if this fails, life is pretty much broken. But the map() calls below aren't wrong.
There was a problem hiding this comment.
I figure if for some reason HOME is unset but XDG_BLAH are we shouldn't fail here. We will fail later though.
This markdown linter is fucking junk. This is the third time it has reported completely fine markdown as invalid. |
|
https://github.com/DavidAnson/markdownlint/blob/main/doc/md007.md according to https://github.com/DavidAnson/markdownlint/blob/main/README.md#tags, it's in the bullet tag. maybe you want more limited tag application? but it purports to report violations of the CommonMark and Github Markdown specs (note that markdown as implemented is very forgiving, so lints should be considered generally warnings). |
|
This is why I have no love for the markdown linting CI steps. I see almost no value, but it adds 2-4 minutes here and there because “reasons” that seem arbituary. |
* Fixes #1103 * Ordering is backwards compatible * Not allowing relative PKGX_DIR which is more sensible and same as pkgx^1
i think the two possible solutions are:
either should work just fine. i use the first. |
|
I’ll install the VSCode plugin |
2 participants
Fixes #1103