Closes optionally_keep_mod_perl_in_env#698
Open
ThisUsedToBeAnEmail wants to merge 1 commit intoplack:masterfrom
Open
Closes optionally_keep_mod_perl_in_env#698ThisUsedToBeAnEmail wants to merge 1 commit intoplack:masterfrom
ThisUsedToBeAnEmail wants to merge 1 commit intoplack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent hours over the past week debugging a problem with another service which is pure CGI and not Plack. MOD_PERL should have always been available to it. In the end I discovered it was based upon which application loaded in the thread first. If the application which was using Plack::Handler::Apache2 instantiated first then the MOD_PERL env variable would not be available in that thread, this caused all my other applications which do not use this handler to instantiate without MOD_PERL. This was problematic as some of them are CGI and have logic which requires it to be available.
Here is a patch, I'm unsure whether it is the best approach, but it resolved my headache.
Regards,
LNATION.