Open
Conversation
eg. recvmsg, the buf address may be in mprotect, the kernel would return err. We have to hook the system call and retry :(.
bpowers
requested changes
Dec 17, 2021
Member
bpowers
left a comment
bpowers
left a comment
There was a problem hiding this comment.
Hi @kyoguan! Thanks for this, and sorry for the very long delay.
I cherry-picked two of the commits that were clear bug fixes (the FD leak and recv rely bits).
For making fork faster, I believe that not using the bitmap will undo the physical memory savings we gain by meshing -- in other words I think the 8x speed improvement comes at the cost of losing our reclaimed/meshed memory. I think ideally we would have a unit test here to verify the RSS of the child after fork. Maybe I am misunderstanding though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.