Update Dockerfile to create non-root user with UID 1000#158
Open
EmCmEdT wants to merge 1 commit intoplasmicapp:masterfrom
Open
Update Dockerfile to create non-root user with UID 1000#158EmCmEdT wants to merge 1 commit intoplasmicapp:masterfrom
EmCmEdT wants to merge 1 commit intoplasmicapp:masterfrom
Conversation
|
@EmCmEdT is attempting to deploy a commit to the Plasmic Team on Vercel. A member of the Team first needs to authorize it. |
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read, agree to, and hereby sign Plasmic's Individual Contributor License Agreement |
sampullman
reviewed
Dec 22, 2025
| RUN addgroup -S plasmic && \ | ||
| adduser -S plasmic -G plasmic && \ | ||
| # Delete container default node user | ||
| RUN deluser --remove-home node 2>/dev/null || true && \ |
Contributor
There was a problem hiding this comment.
Makes sense to me! But maybe it's possible to just use the builtin node user, if it doesn't break anything?
Author
There was a problem hiding this comment.
I can't say. I know very little about node users.
Contributor
There was a problem hiding this comment.
I just mean that the node:24-alpine has a user already (called node), so we can just use that. I'll test it out when I get the chance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref:
https://forum.plasmic.app/t/docker-compose-file-not-working/10939/14