Skip to content

Add init and configure event to AppBase #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucaheft wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add init and configure event to AppBase #8188

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c56137
Add init and configure event to AppBase
Nov 27, 2025
a366f5c
Merge branch 'main' into app-events
Nov 27, 2025
af2754f
Add jsdoc for events
Nov 27, 2025
7efa001
Rename configure event to config:loaded, adjust event doc
Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/framework/app-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,8 @@ class AppBase extends EventHandler {
// bind tick function to current scope
/* eslint-disable-next-line no-use-before-define */
this.tick = makeTick(this); // Circular linting issue as makeTick and Application reference each other

this.fire('init');
}

static _applications = {};
Expand Down Expand Up @@ -690,6 +692,7 @@ class AppBase extends EventHandler {
this._parseScenes(scenes);
this._parseAssets(assets);
if (!err) {
this.fire('configure');
callback(null);
} else {
callback(err);
Expand Down