Fixed unecessary axes array reallocation in GamePad update - Issue (#…#8203
Open
kartik815 wants to merge 1 commit intoplaycanvas:mainfrom
Open
Fixed unecessary axes array reallocation in GamePad update - Issue (#…#8203kartik815 wants to merge 1 commit intoplaycanvas:mainfrom
kartik815 wants to merge 1 commit intoplaycanvas:mainfrom
Conversation
slimbuck
reviewed
Nov 30, 2025
|
|
||
| for (let j = 0, m = buttons.length; j < m; j++) { | ||
| const button = buttons[i]; | ||
| const button = buttons[j]; |
Member
There was a problem hiding this comment.
did you mean to change i -> j?
Author
There was a problem hiding this comment.
Yes — this change was intentional.
The inner loop iterates using j, but the original code accessed buttons[i].
That caused incorrect indexing since i belongs to the outer loop.
This was a small existing bug that I fixed while making the main change (in-place axes updates).
If you'd prefer, I can move this fix into a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize Receiving Objects Step to Reduce Initialization Delay (#842)
Description
This PR addresses issue #842 by improving the performance of the receiving objects step in the engine.
It reduces the delay when processing incoming objects, ensuring smoother initialization and better overall responsiveness.
Fixes #842
Checklist