Open
Conversation
Avasam
force-pushed
the
external-codes
branch
from
a452fa8 to
5728793
Compare
Author
|
@plinss could I get a review on this? It would be quite useful for better interoperability between Ruff and Flake8-pyi + Flake8-noqa in the typeshed repository. |
Mujtaba-345
approved these changes
Mar 27, 2024
|
I'd really love this option as I currently have to choose between deadcode and this addon. Is there a reason why it is stale? |
Avasam
force-pushed
the
external-codes
branch
from
5728793 to
e46bf57
Compare
Avasam
force-pushed
the
external-codes
branch
from
e46bf57 to
7bbc0b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22 . Allows interoperability with tools like Vulture and Ruff.
Naming based on https://docs.astral.sh/ruff/settings/#external
As part of my changes I've made set manipulations in the
violationsmethod more concise and avoid unneeded pure-python iterations.I can't run tests that expect errors locally because the temp test folder is always added to the output, which differs from the expected strings.