Conversation
* Fix useFont example in docs * Remove unused imports from Text3D * Use TTFLoader in useFont * Update documentation for Text3D * Add story for Text3D using TTFLoader * ttf font --------- Co-authored-by: Antoine BERNIER <antoine.bernier@gmail.com>
To avoid a breaking change, this only uses `TTFLoader` when the `ttfLoader` argument of `useFont` is set to `true`.
|
@mz8i is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Why wasn't feature detection in #2095 done by looking at the file extension? |
|
Originally I thought detecting based on MIME type would be more generic. But I removed the detection anyway - correct me if I'm wrong, but I think any sort of detection would potentially be a breaking change for users who rely on the hook to always apply |
|
@abernier @CodyJasonBennett would you have any more comments about this PR? |
2 participants
Resolves #2094
(this is a second PR after #2095 got reverted to avoid a breaking change).
In comparison to the previous PR, the code here does not try to automatically determine if
TTFLoadershould be used.It is only enabled manually through the second argument to
useFont.Additional considerations:
reversedoption toTTFLoader, which is required to correctly parse some font files. Suggestions for the cleanest API here are welcome.preloadandclearfunctions foruseFontin the case whereuseFonthas more than one argument.Why
What
Checklist