Skip to content

Fix gnome 49 compatibility #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sasilanz wants to merge 2 commits into
base: master_noble
Choose a base branch
from
Open

Fix gnome 49 compatibility #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ee93d5
Fix compatibility with GNOME Shell 49
sasilanz Dec 31, 2025
c374508
fix: resolve build errors and WindowSwitcherPopup settings crash in G…
sasilanz Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,10 +909,10 @@ export class Ext extends Ecs.System<ExtEvent> {
) {
if (prev.rect().contains(win.rect())) {
if (prev.is_maximized()) {
prev.meta.unmaximize(Meta.MaximizeFlags.BOTH);
prev.meta.unmaximize();
}
} else if (prev.stack) {
prev.meta.unmaximize(Meta.MaximizeFlags.BOTH);
prev.meta.unmaximize();
this.auto_tiler.forest.stacks.get(prev.stack)?.restack();
}
}
Expand Down Expand Up @@ -1034,7 +1034,7 @@ export class Ext extends Ecs.System<ExtEvent> {
compare.is_maximized() &&
win.entity[0] !== compare.entity[0]
) {
compare.meta.unmaximize(Meta.MaximizeFlags.BOTH);
compare.meta.unmaximize();
}
}
}
Expand Down Expand Up @@ -1258,9 +1258,7 @@ export class Ext extends Ecs.System<ExtEvent> {

if (this.auto_tiler) {
if (this.is_floating(win)) {
win.meta.unmaximize(Meta.MaximizeFlags.HORIZONTAL);
win.meta.unmaximize(Meta.MaximizeFlags.VERTICAL);
win.meta.unmaximize(Meta.MaximizeFlags.BOTH);
win.meta.unmaximize();
}

this.register(Events.window_move(this, win, rect));
Expand Down Expand Up @@ -2964,7 +2962,9 @@ function _show_skip_taskbar_windows(ext: Ext) {
WindowSwitcherPopup.prototype._getWindowList = function () {
let workspace = null;

if (this._settings.get_boolean('current-workspace-only')) {
// Use local settings instance since this._settings may be null in GNOME 49+
let settings = new Gio.Settings({ schema_id: 'org.gnome.shell.app-switcher' });
if (settings.get_boolean('current-workspace-only')) {
let workspaceManager = global.workspace_manager;
workspace = workspaceManager.get_active_workspace();
}
Expand Down
2 changes: 1 addition & 1 deletion src/mod.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ declare namespace Meta {
move_resize_frame(user_op: boolean, x: number, y: number, w: number, h: number): boolean;
raise(): void;
skip_taskbar: boolean;
unmaximize(flags: any): void;
unmaximize(flags?: any): void;
unminimize(): void;
}

Expand Down
2 changes: 1 addition & 1 deletion src/tiling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ export class Tiler {
this.window = win.entity;

if (win.is_maximized()) {
win.meta.unmaximize(Meta.MaximizeFlags.BOTH);
win.meta.unmaximize();
}

// Set overlay to match window
Expand Down
2 changes: 1 addition & 1 deletion src/window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ export class ShellWindow {

if (actor) {
if (this.is_maximized()) {
meta.unmaximize(Meta.MaximizeFlags.BOTH);
meta.unmaximize();
}
actor.remove_all_transitions();

Expand Down