Security: replace abandoned pkg coveralls with coveralls-next#305
Conversation
|
Looks like we need to generate lock files using 14/16 Node.js, can you do it using nvm? |
006d3ef to
c17bade
Compare
c17bade to
f73c495
Compare
|
@alexander-akait it might have been because of the lockfileVersion. nvm didn't work for me as going back to node 14 requires me to have an older version of python:
Fortunately, there is the node:14-slim docker image and it worked perfect. Could you check if the pipelines is going to pass now? P.S There are also other security risks as flagged by npm, but I'm not sure whether to use this PR to resolve all. What are your thoughts on this?
|
|
Thanks |
The
requestpackage through 2.88.2 for Node.js allow a bypass of SSRF mitigations via an attacker-controller server that does a cross-protocol redirect (HTTP to HTTPS, or HTTPS to HTTP).The request package is no longer supported by the maintainer. Unfortunately, it's a dependency of the
coverallspackage, which also seems abandoned. This PR helps by replacing the coveralls package with coveralls-next.