Encryption part 2: Use common SDK for Swift build#277
Merged
Conversation
simolus3
force-pushed
the
swift-sdk-common
branch
2 times, most recently
from
60e2acb to
49352a6
Compare
simolus3
force-pushed
the
swift-sdk-common
branch
from
49352a6 to
cdf6bfe
Compare
stevensJourney
approved these changes
Oct 23, 2025
Contributor
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
This looks good to me :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the Swift helpers to use the
:commonpackage instead of:core, meaning that sqlite3 will no longer be linked into the created framework.This adds helpers to
:commonmaking it easier to replicate the default connection factory from:core. This is now used in the Swift helper to add a function returning such as a connection factory. The connection factory can be customized with statements to run when the connection is initialized. This is useful to e.g. set aPRAGMA key =.This will be used in the Swift SDK like shown in this PR: powersync-ja/powersync-swift#82. To unblock Swift after these changes, see powersync-ja/powersync-swift#83.