Add docker ci jobs scripts for test-infra repo#244
Add docker ci jobs scripts for test-infra repo#244ppc64le-cloud-bot merged 1 commit intoppc64le-cloud:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AshwinHIBM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
approved
|
looks simple enough. where does the prow job config live? i should probably take another look at that as well to refresh my memory |
Sure, it's in a PR: ppc64le-cloud/test-infra#517 |
ppc64le-cloud-bot
added
size/M
clnperez
left a comment
clnperez
left a comment
There was a problem hiding this comment.
could you also add more detail to the title, summary, and git commit?
setup-pj-trigger.sh
Outdated
| @@ -0,0 +1,25 @@ | |||
| #!/bin/bash | |||
|
|
|||
| echo "Triggering the next prow job using git commit" | |||
There was a problem hiding this comment.
can you include a bit more detail here about where the commit is to? this repo? which file?
There was a problem hiding this comment.
Thanks. Added more details about where the commit is made: https://github.com/ppc64le-cloud/docker-ce-build/compare/e2f8d3408054dd95161018b8782669b045dbfeff..e028a45789c3b44db95f990f9b9d84f1973b2e42
| while getopts ":r:" option; do | ||
| case "${option}" in | ||
| r) | ||
| TRACKING_REPO=${OPTARG} |
There was a problem hiding this comment.
It'll be populated with the value of the -r flag, here REPO_OWNER/REPO_NAME. REPO_OWNER/REPO_NAME = ppc64le-cloud/docker-ce-build here.
| chmod ug+x ./setup-pj-trigger.sh | ||
| ./setup-pj-trigger.sh -r ppc64le-cloud/docker-ce-build | ||
| else | ||
| echo "The kernel is not suitable to run Docker." |
There was a problem hiding this comment.
is this error message really the only possible explanation we could get back a non-zero rc from info.sh?
There was a problem hiding this comment.
The output of the script, which is also logged, uses color codes to show what's wrong. The exit code however will either be 0 or 1 as returned by https://github.com/moby/moby/blob/master/contrib/check-config.sh.
There was a problem hiding this comment.
i was asking if there could be other problems than a kernel problem. i looked at the script and its sole purpose is to check the kernel config. so, that answers that question. could you change the error message to: "Error checking the kernel configuration" ? and in the echo on line 22, modify "Check Config" to "Checking Kernel Config"
There was a problem hiding this comment.
actually n/m. that is run inside this script. this script could also fail if there are directory problems for example, IIUC:
AshwinHIBM
force-pushed
the
ci
branch
2 times, most recently
from
e028a45 to
7b92d27
Compare
AshwinHIBM
changed the title
AshwinHIBM
changed the title
clnperez
changed the title
These scripts are triggered by their respective test infra jobs, namely prow-info-docker.sh by periodic-config-docker, prow-build-dev-image.sh by periodic-build-dev-image-docker, prow-unit-test-docker.sh by postsubmit-unit-test-docker and prow-integration-tests.sh by postsubmit-integration-test-docker
|
LGTM |
3 participants
The periodic and postsubmit jobs in ppc64le-cloud/test-infra#517 will trigger scripts as per the below specification:
prow-info-docker.sh: triggered byperiodic-config-dockerprow-build-dev-image.shbyperiodic-build-dev-image-dockerprow-unit-test-docker.shbypostsubmit-unit-test-dockerprow-integration-tests.shbypostsubmit-integration-test-docker