Account for alternating angles in reading angle factor

[Givikap120]

Current state of rework is pretty much targeted C-type nerf, as this map gets absurd amount of reading pp, because angles are considered very unrepetitive. What results in this score being worth absurd 1.4k pp.

This PR is up to heavy discussion because it can be made much more general, touching more maps. So I wait on pp committee opinion on what of the parts can be removed.

Current checks for angle to be nerfed:

• The smaller angle has to be very sharp: <18 degrees, full power on <4 degrees
• The larger angle has to be wide: >72 degrees, full power on >117 degrees
• Spacings are alternating together with the angle, meaning that it would go around one note
• Extremely low spaced patterns (less than 1.5 diameters) are excluded from the nerf, so some stream patterns won't be touched

If pattern meets all the criteria - it would be considered repetitive. For now practically no map meets this criteria to significant amount except C-type.

[tsunyoku]

This just feels way too targeted for my liking. This is pretty ugly in that it is littered with a bunch of conditions to satisfy with very specific constants, which I'm not really a fan of.

[Givikap120]

This just feels way too targeted for my liking. This is pretty ugly in that it is littered with a bunch of conditions to satisfy with very specific constants, which I'm not really a fan of.

That was intentional to make the nerf narrow-scoped for specific patterns,
I could show what exactly each check does, and what side-effects of removing it
I would've personally preferred a smoogisheet, but that would probably take way too long, so maybe I can use my local dataset
Should I show the screenshots here, or take it to discord?

[tsunyoku]

Feel free to post anything relevant here.

[Givikap120]

First screenshot is a current deltas. All those scores were manually set to be AR0 to maximize reading pp. So you could expect much smaller deltas on the real maps.

As we could see here - the effect on other maps except C-type is pretty small.
We could see a bunch of alt maps here and oshama scramble (probably from the part where you have go from fast slider to slow slider and repeat it multiple times).

[Givikap120]

The next is deltas from removing the check on small spacings. As explained in the comment - this check exists to avoid nerfs on streams maps.

Removing the check results in various stream and alt maps getting nerfed, but the difference is not very major.

[Givikap120]

The next check is for spacings being similar. As there's not a lot of point in checking repetitive alternating angles if spacings of the jumps are random and unpredictable.

The deltas here are much much larger than in previous check, and in some cases they're comparable with c-type nerf level (such as on the "Tatarigami" map (https://osu.ppy.sh/beatmapsets/724673#osu/1530206)
Also we could see the major hit on uncomfy aim maps that utulize a lot of wide angle jumps, as well as noticeable nerf on pretty much all alt maps I had in the collection. Also there's more nerf on doubles as we could see. Specifically those who are not completely stacked.
Removing this check completely would be pretty painful, so I think it should be reworked in some way instead.

Nerfed pattern on Tatarigami:

[Givikap120]

The last check is for one of the angles being sharp and other being wide.

Removing this check completely is not an option, because it completely ruins the whole algorithm: maps with many sharp angled jumps that are not really alternating are suffering major nerf, when alternating angle maps are barely touched because the difference between 180 degree and 150 degree is considered the same as between 0 degree and 30 degree, even though on practice it doesn't feels that way.

Instead those are the deltas of limits being expanded to include much more sharp angled angles, as currently it mainly targets angles very close to 0 degrees.

As we could see the amount of affected maps is actually not that big, but ones that are affected - affected significantly. The 2 outlier maps here are 5150 (https://osu.ppy.sh/beatmapsets/812921#osu/1704984) and dreamin attraction (https://osu.ppy.sh/beatmapsets/2211043#osu/4683658).
First map is nerfed most likely because of the doubles in the end, when second one has a lot of aim-control streams that change directions.

Nerfed pattern in 5150:

The most nerfed pattern in Dreamin Attraction:

[Givikap120]

@tsunyoku that has to be all relevant info atm.
To find more maps to check the formulas on you would probably have to run smoogisheet on version with disabled checks.