fix: use export = instead of esm exports for jsx export types#444
Open
dsherret wants to merge 2 commits intopreactjs:mainfrom
Open
fix: use export = instead of esm exports for jsx export types#444dsherret wants to merge 2 commits intopreactjs:mainfrom
export = instead of esm exports for jsx export types#444dsherret wants to merge 2 commits intopreactjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e5ff19f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dsherret
changed the title
dsherret
changed the title
export = instead of esm exports for jsx export types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what's up with this file appearing twice (probably compat for before exports existed? Is it still worth having?), but this is a hacky fix for the default export being wrong.
The fix is to just write the declaration files using
export =instead of esm exports because typescript resolves these as cjs. This makes the package work now when imported from ESM.Closes #443