Skip to content

Refactor mapping tester using snake style naming#162

Open
kursatyurt wants to merge 2 commits intodevelopfrom
refactor_mapping_tester
Open

Refactor mapping tester using snake style naming#162
kursatyurt wants to merge 2 commits intodevelopfrom
refactor_mapping_tester

Conversation

@kursatyurt
Copy link
Collaborator

@kursatyurt kursatyurt commented Dec 12, 2022

Main changes of this PR

Refactoring mapping tester using snake naming convention. It follows the preCICE convention

C++ codes -> CamelCase
Python Scripts -> snake_case

Author's checklist

  • I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
  • I added a test to cover the proposed changes in our test suite.
  • I updated the documentation in docs/README.md.
  • I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

@kursatyurt kursatyurt changed the title Refactor using snake style naming Refactor mapping tester using snake style naming Dec 12, 2022
@kursatyurt kursatyurt requested a review from davidscn December 12, 2022 16:13
Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look at the failing tests?

I'm not too sure about renaming the python scripts as well. Note that the generate script generates runall.sh as well as postprocessall.sh. Do you also want to rename these files then? Maybe a better name for generate_mapping_test would be generate_mapping_test_cases?


# Prepare the meshes
python3 "${MAPPING_TESTER}"/preparemeshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force
python3 "${MAPPING_TESTER}"/prepare_mapping_teest_meshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3 "${MAPPING_TESTER}"/prepare_mapping_teest_meshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force
python3 "${MAPPING_TESTER}"/prepare_mapping_test_meshes.py --setup "${TEST_LOCATION}"/setup-test.json --outdir "${TEST_CASE_LOCATION}" --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants