Skip to content

Include link path in rpath#241

Draft
davidscn wants to merge 4 commits intoprecice:developfrom
davidscn:cmake-4
Draft

Include link path in rpath#241
davidscn wants to merge 4 commits intoprecice:developfrom
davidscn:cmake-4

Conversation

@davidscn
Copy link
Member

@davidscn davidscn commented Apr 1, 2025

Main changes of this PR

Affecting breaking changes in CMake version 4

https://cmake.org/cmake/help/v4.0/prop_tgt/MACOSX_RPATH.html
https://cmake.org/cmake/help/latest/policy/CMP0042.html#policy:CMP0042

Author's checklist

  • I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
  • I added a test to cover the proposed changes in our test suite.
  • I updated the documentation in docs/README.md.
  • I added a changelog entry in ./changelog-entries/ (create if necessary).
  • I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

@davidscn davidscn requested a review from fsimonis April 1, 2025 12:25
@fsimonis
Copy link
Member

I see that the macOS CI on develop succeeds. Do we still need this?

@davidscn
Copy link
Member Author

I realized only this week that the cron job I put in place was automatically disabled. Waiting now for the job of the next week to run and check the result. IIRC, the problem was actually fixed, but let's check the CI.

@davidscn
Copy link
Member Author

davidscn commented Aug 26, 2025

I see that the macOS CI on develop succeeds. Do we still need this?

That's not the case anymore. Do you have any idea if this is related to cmake 4?

@fsimonis
Copy link
Member

fsimonis commented Aug 26, 2025

The exact same error was triggered in #214. There seemed to be an issue with a package or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants