Add error message for invalid event data names#22
Open
s3n-w6i wants to merge 2 commits intoprecice:mainfrom
Open
Add error message for invalid event data names#22s3n-w6i wants to merge 2 commits intoprecice:mainfrom
s3n-w6i wants to merge 2 commits intoprecice:mainfrom
Conversation
Otherwise, this will cause the program to error with a column count mismatch error. This is really hard to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my profiling, I added an event to preCICE that wrote custom data named
rank. When I went to runprecice-profiling-exporton it, I received the following error:After some digging, it turns out that this mismatch in columns is due to a collision between the
rankfield that is included by default in the exported CSV file and therankI added as custom event data.I added an assertion that catches this duplicate and prints a custom error message, so that the user knows what's going on:
Alternatives considered