Remove iconv conditional require#170
Merged
grosser merged 1 commit intopremailer:masterfrom Dec 12, 2024
Merged
Conversation
Drop legacy character encoding support for Ruby versions prior to 1.9, as string encoding is now natively supported in modern Ruby versions.
tagliala
force-pushed
the
chore/remove-iconv
branch
from
fbd1e64 to
b807af1
Compare
Contributor
|
1.20.0 |
Contributor
Author
|
@grosser I'm seeing that there are several There is also a rubocop/performance cop with safe autofix for this use case, are you interested in this change? |
Contributor
|
yeah, best update rubocop and auto-fix them :)
…On Thu, Dec 12, 2024 at 8:14 AM Geremia Taglialatela < ***@***.***> wrote:
@grosser <https://github.com/grosser> I'm seeing that there are several string
=~ regexp that can be converted to regexp.match?(string) to improve
performance and eliminate memory consumption
There is also a rubocop/performance cop with safe autofix for this use
case, are you interested in this change?
—
Reply to this email directly, view it on GitHub
<#170 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZ4UCUAEUISBEDNDVP32FGY7TAVCNFSM6AAAAABTPHUFHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZGQYDEMJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop legacy character encoding support for Ruby versions prior to 1.9, as string encoding is now natively supported in modern Ruby versions.
Why and what is being done.
Pre-Merge Checklist