Change open colors to blue for tritanopia and colorblind#1235
Change open colors to blue for tritanopia and colorblind#1235lukasoppermann wants to merge 20 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 292a4e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Design Token Diff (CSS)The message is too long to be displayed here. For more details, please check the job summary. |
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Design Token Diff (Figma)The message is too long to be displayed here. For more details, please check the job summary. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the “open” token colors (foreground, border, background) for colorblind and tritanopia simulations, switching from red/orange to blue shades.
- Removed old orange/red overrides for colorblind themes in fgColor, borderColor, and bgColor.
- Introduced (via placeholder) new blue-based overrides (to be implemented).
- Added a changeset for the patch release.
Reviewed Changes
Copilot reviewed 4 out of 34 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/tokens/functional/color/fgColor.json5 | Cleared old colorblind overrides for open fgColor tokens. |
| src/tokens/functional/color/borderColor.json5 | Cleared old colorblind overrides for open borders. |
| src/tokens/functional/color/bgColor.json5 | Cleared old colorblind overrides for open backgrounds. |
| .changeset/modern-items-notice.md | Added patch release note about switching to blue overrides. |
Comments suppressed due to low confidence (1)
src/tokens/functional/color/fgColor.json5:229
- [nitpick] Consider adding automated or visual regression tests to verify the new blue overrides render correctly in tritanopia, protanopia, and deuteranopia simulations.
'org.primer.overrides': {
|
From slack
Result: |
586a73e to
4a895a2
Compare
4c989be to
edd3f75
Compare
|
Hi @lukasoppermann 👋🏻 What's the status on this PR? It looks like it's been approved though I see a few conflicts to resolve. Is the plan to merge this? |





This fixes https://github.com/github/primer/issues/4846 and https://github.com/github/primer/issues/4667
Latest changes
Previous changes
After change
Default

Tritanopia (simulation)

Protanopia (simulation)

Deuteranopia (simulation)

Before change (current)
Default

Tritanopia (simulation)

Protanopia (simulation)

Deuteranopia (simulation)

List of notable changes:
bgColor.open.[...],borderColor.open.[...]andfgColor.opento use blue instead of red / orange in tritanopia, deuteranopia and protanopia.drafttoken is always grayNext steps