Update bake_metal to support mixed BSDF and top-layer node groups#291
Open
haoliu-meta wants to merge 1 commit intoprinceton-vl:mainfrom
Open
Update bake_metal to support mixed BSDF and top-layer node groups#291haoliu-meta wants to merge 1 commit intoprinceton-vl:mainfrom
haoliu-meta wants to merge 1 commit intoprinceton-vl:mainfrom
Conversation
Contributor
|
Apologies, I did not see your original issue until just now. Anyways, thank you for the PR and I will take a look soon. |
Author
|
The lint failure seems unrelated? Any chance of merging? |
Collaborator
|
Hello, thanks again for the PR. The lint failure does seem unrelated. Im keen to merge this but it will have to wait for the timebeing as I want to make sure David can review, and he is out of office for another week or so. Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to solve for #285
Example of metallic vs. diffuse map of a
TVMetallic
Diffuse
