Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
A more elaborate version of what Matt built, with all columns named by the type they have: |
Contributor
|
Not sure if this is intentional or not, but one thing to note here is that I think it's important to test types like |
Contributor
|
Contributor
Author
How so? |
Contributor
|
You probably want something like: Some variety to ensure that introspection can also handle explicit parameters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need databases that have all the types possible in MySQL, Postgres and SQLite. This PR adds a new database
referencethat has atypestable that has an@id(ID int(11) auto increment as Primary Key) and one column per possible type.Source for types:
For MySQL the columns are roughly named and sorted by the structure of the reference documentation, so the name is enough to recognize the original type.
The type "parameter" (e.g.
255forVARCHAR) is e.g. the default, if you create the column without setting a value or a reasonable enough manually chosen value.MySQL

typestable in phpMyAdmin: