[DT-3158] feat: import from github in reuse existing slices dialog#1754
Merged
jomifepe merged 36 commits intojp/import-slice-basefrom Dec 29, 2025
Merged
[DT-3158] feat: import from github in reuse existing slices dialog#1754jomifepe merged 36 commits intojp/import-slice-basefrom
jomifepe merged 36 commits intojp/import-slice-basefrom
Conversation
refactor: remove previous update modal refactor: remove slices location
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
refactor: share types
xrutayisire
requested changes
Dec 22, 2025
...e/src/features/customTypes/customTypesBuilder/ImportSlicesFromLibraryModal/DialogButtons.tsx
Outdated
Show resolved
Hide resolved
...customTypes/customTypesBuilder/ImportSlicesFromLibraryModal/ImportSlicesFromLibraryModal.tsx
Outdated
Show resolved
Hide resolved
...s/customTypes/customTypesBuilder/ImportSlicesFromLibraryModal/LibrarySlicesDialogContent.tsx
Outdated
Show resolved
Hide resolved
...s/customTypes/customTypesBuilder/ImportSlicesFromLibraryModal/LibrarySlicesDialogContent.tsx
Outdated
Show resolved
Hide resolved
...s/customTypes/customTypesBuilder/ImportSlicesFromLibraryModal/LibrarySlicesDialogContent.tsx
Outdated
Show resolved
Hide resolved
...s/customTypes/customTypesBuilder/ImportSlicesFromLibraryModal/LibrarySlicesDialogContent.tsx
Outdated
Show resolved
Hide resolved
...stomTypes/customTypesBuilder/ImportSlicesFromLibraryModal/hooks/useImportSlicesFromGithub.ts
Outdated
Show resolved
Hide resolved
...ges/slice-machine/src/features/customTypes/customTypesBuilder/shared/getSubmitButtonLabel.ts
Outdated
Show resolved
Hide resolved
fix: reset tab on close refactor: match onSuccess types to the previous ones
refactor: renaming
refactor: remove unnecessary mock updating code
xrutayisire
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: DT-3158
Description
Local slicesandLibrary slices.Reuse and existing slicefunctionality to theLocal slicetab and the new GitHub importing feature in theLibrary slicestab.Reuse an existing sliceonePreview
Clipboard-20251218-180218-916.mp4
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩