chore(skore): Turn pytest warnings into errors#2082
Draft
thomass-dev wants to merge 1 commit intomainfrom
Draft
Conversation
Contributor
thomass-dev
force-pushed
the
skore-raise-warning
branch
from
95115ec to
6cc760a
Compare
thomass-dev
pushed a commit
that referenced
this pull request
Oct 29, 2025
Start applying the [settings suggested](https://learn.scientific-python.org/development/guides/pytest/#configuring-pytest) by [Repo-Review](https://learn.scientific-python.org/development/guides/repo-review/?repo=probabl-ai%2Fskore&ref=HEAD&refType=branch): * **PP308**: `-ra` will print a summary “r”eport of “a”ll results, which gives you a quick way to review what tests failed and were skipped, and why. * **PP307**: `--strict-markers` will make sure you don’t try to use an unspecified fixture. * **PP306**: And `--strict-config` will error if you make a mistake in your config. * **PP305**: `xfail_strict` will change the default for `xfail` to fail the tests if it doesn’t fail - you can still override locally in a specific xfail for a flaky failure. * **PP304**: `log_cli_level` will report INFO and above log messages on a failure. This PR comes as a complement of #2082, which applies this suggestion: * **PP309**: `filter_warnings` will cause all warnings to be errors (you can add allowed warnings here too).
glemaitre
pushed a commit
to auguste-probabl/skore
that referenced
this pull request
Jan 16, 2026
Start applying the [settings suggested](https://learn.scientific-python.org/development/guides/pytest/#configuring-pytest) by [Repo-Review](https://learn.scientific-python.org/development/guides/repo-review/?repo=probabl-ai%2Fskore&ref=HEAD&refType=branch): * **PP308**: `-ra` will print a summary “r”eport of “a”ll results, which gives you a quick way to review what tests failed and were skipped, and why. * **PP307**: `--strict-markers` will make sure you don’t try to use an unspecified fixture. * **PP306**: And `--strict-config` will error if you make a mistake in your config. * **PP305**: `xfail_strict` will change the default for `xfail` to fail the tests if it doesn’t fail - you can still override locally in a specific xfail for a flaky failure. * **PP304**: `log_cli_level` will report INFO and above log messages on a failure. This PR comes as a complement of probabl-ai#2082, which applies this suggestion: * **PP309**: `filter_warnings` will cause all warnings to be errors (you can add allowed warnings here too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.