Skip to content

Conversation

@auguste-probabl
Copy link
Collaborator

@auguste-probabl auguste-probabl commented Feb 3, 2026

Closes #1840

@auguste-probabl auguste-probabl marked this pull request as draft February 3, 2026 09:43
@auguste-probabl auguste-probabl changed the title Upload coverage to codecov ci: Upload coverage to codecov Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@auguste-probabl
Copy link
Collaborator Author

To really test this, the PR needs to be merged to main; I need to test this in a copy of the repo.

thomass-dev

This comment was marked as resolved.

@auguste-probabl

This comment was marked as resolved.

@thomass-dev

This comment was marked as resolved.

@thomass-dev
Copy link
Collaborator

In that case, if codecov is in charge of displaying the coverage, please remove the .github/workflows/pr-display-code-coverage.yml workflow.

@thomass-dev
Copy link
Collaborator

Note: please ensure that the coverage of each package (in our mono-repo/multi-package environment) is well managed/identified.

@auguste-probabl
Copy link
Collaborator Author

@thomass-dev I did some experimenting in a copy of the repo, because I need the Codecov step to have run on main to get the diff for a PR. Here is what I did in main: auguste-probabl/skore-copy@4091b54...main

And then I opened a PR: auguste-probabl/skore-copy#3

But it's not necessarily iso with our current setup, with the segmentation between maintainers and external contributors, etc.

Would you mind reviewing what I did on my copy here? Do you think this would work for us? And also we'll have to get a token from Codecov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Add codecov to better interpret python coverage

2 participants