fix: resolve structural duplication and localization errors in hi.json(#3812) #3813
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
There was a problem hiding this comment.
Pull request overview
This PR aims to fix structural duplication and localization errors in the Hindi translation file (hi.json). The changes address a major structural defect where the JSON restarted after the AssetList section, causing duplicate key definitions.
Changes:
- Removed large redundant duplicate JSON block that caused parsing conflicts
- Standardized technical terminology (Asset → "ऐसेट", Variable → "वैरिएबल")
- Added missing library management keys (CustomVersionTitle, CustomVersionInfo, CustomVersionReset) to Preferences
- Added missing keys to About section (EmailAddress, Contact)
- Added validation string (errorEmptyEmailorUserName) to ReduxFormUtils
- Added RenameVariable keyboard shortcut translation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yugalkaushik
left a comment
yugalkaushik
left a comment
There was a problem hiding this comment.
I can see that multiple blocks of translations are missing. I suggest please review this PR again and only make the required changes. It is not optimal to completely change the entire translation.
|
Hi @yugalkaushik, thank you for the feedback! I’ve double-checked the translations/locales/hi/translations.json file against the current master branch. This PR is specifically focused on fixing structural duplications and standardizing keys rather than a full rewrite, so I want to make sure I haven't overlooked anything. Could you please point out any specific blocks or key paths you feel are missing? Having concrete examples would really help me address your concerns accurately and move this PR forward. Also, a gentle note: commenting on every PR with non-specific feedback can be discouraging for contributors, especially newer ones. Precise and actionable reviews help maintain both code quality and contributor morale in open-source projects. |
|
@Urvi2727 Sorry if my reviews came off as discouraging, that genuinely wasn’t the intention. Reviews are meant to help improve things, not slow anyone down, even if they sometimes land that way. If my feedback isn’t adding value here, I’m happy to step back and won’t review your PRs going forward, so you can have full authority over this one and move it ahead without the extra noise. Also, speaking for myself, I’ve added detailed notes on what’s missing in other PRs, which you’re welcome to check. For this PR specifically, the translation files are structured to match en.json, which is the default translation used across the codebase, if they don’t follow that structure in other translations, the translations won’t work at all. Appreciate the effort you’ve put in and hope this gets merged smoothly. |
2 participants
Fixes #3812
Fixes #3485
Overview
This PR cleans up the existing Hindi localization file by fixing major structural defects and standardizing technical terminology for a better developer experience.
Key Changes
Structural Deduplication: Removed a large redundant block where the JSON restarted after AssetList, resolving potential parsing conflicts.
Technical Standardization: * Unified "Asset" as "ऐसेट" (transliterated) instead of the literal "संपत्ति" for better technical context.
Corrected "Variable" rename shortcut from "चरण" to the standard "वैरिएबल".
Missing Localizations:
Translated the English Banner text into Hindi.
Added absent library management keys (CustomVersionTitle, CustomVersionInfo) to the Preferences section.
Validation Sync: Consolidated fragmented password and email validation strings in NewPasswordView to match the core application logic.